Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-36617] migrate kyro package #25583

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FLINK-36617] migrate kyro package #25583

wants to merge 1 commit into from

Conversation

r-sidd
Copy link
Contributor

@r-sidd r-sidd commented Oct 28, 2024

What is the purpose of the change

Migrate kryo package

Brief change log

Kryo has been moved to the com.esotericsoftware package. Updating to this version will enhance capabilities, ensure the dependency is up to date, and address vulnerabilities in the current dependencies, specifically CVE-2020-15250

Package details: https://mvnrepository.com/artifact/com.esotericsoftware/kryo/4.0.3

Updating to version 4.0.3, as higher versions are causing local build failures.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: don't know
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 28, 2024 •
edited
Loading

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@tomncooper
Copy link
Contributor

Looks like you have conflicting versions of org.ow2.asm:asm. You may need to override the transitive versions of kryo from other packages (in this case the one coming from com.twitter:chill-java in flink-streaming-java) in order to get the build to work.

@r-sidd
Copy link
Contributor Author

r-sidd commented Dec 18, 2024

Looks like you have conflicting versions of org.ow2.asm:asm. You may need to override the transitive versions of kryo from other packages (in this case the one coming from com.twitter:chill-java in flink-streaming-java) in order to get the build to work.

Hey thanks for the guidance, I'll try to make the necessary adjustments to get the build working.

@snuyanzin
Copy link
Contributor

isn't it a duplicate of
#22660
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=<none>
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r-sidd @flinkbot @tomncooper @snuyanzin